Fix Create Github Release workflow node_modules permissions#429
Merged
turegjorup merged 2 commits intoMay 5, 2026
Conversation
The node compose service ran as root, leaving root-owned files in the bind-mounted node_modules/. The runner-side Cleanup before packaging step then could not rm them and the release was never created. - Add overridable user to the node service (defaults to root so local-dev behavior is unchanged). - Set COMPOSE_NODE_USER to the runner UID:GID and pass HOME=/tmp so npm can write its cache when not running as root. - Align .dockerignore with the workflow's cleanup list (phpstan-baseline.neon, /playwright/). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Create Github Releaseworkflow failing atCleanup before packagingbecause root-owned files from thenodecompose service could not be removed by the runner.userto thenodeservice (defaults torootso local-dev is unchanged).COMPOSE_NODE_USERto the runner's UID:GID and passHOME=/tmpso npm can write its cache when not running as root..dockerignorewith the workflow'sCleanup before packaginglist (/phpstan-baseline.neon,/playwright/).Why scoped to a new
COMPOSE_NODE_USERinstead of reusingCOMPOSE_USER: thenode:24image has no built-in non-root user matching the runner UID, whileitkdev/php8.4-fpm:alpinedoes (viarunner). ReusingCOMPOSE_USERwould require touching the eleven other workflows that already rely on it for phpfpm.Test plan
0.0.0-test3produced a successful workflow run (1m31s),Cleanup before packagingpassed, the GitHub release was created and assets (*.tar.gz,checksum.txt) uploaded.docker compose run node …still works unchanged (root default preserved).release/3.0.0after merge to verify end-to-end.🤖 Generated with Claude Code